Duplication in chain registration commands

sitetester commented 11 months ago

Description

https://github.com/LiskHQ/lisk-sdk/pull/9043 In this PR, duplication of registration commands was addressed by moving common code to parent class, but since it involved an out of scope change of relevant task, we can address it here.

What to do ? Take relevant duplication of code (AND test cases) from above PR & either address it in the same PR (by re-opening it) or create another one.

Motivation

There were duplication for whole blocks like verifyValidators
Same set of tests were written for sidechain & mainchain
Take a look at base class methods how duplication for other parts is handled

Additional Information

framework/src/modules/interoperability/base_interoperability_register_chain_command.ts
framework/src/modules/interoperability/mainchain/commands/register_sidechain.ts
framework/src/modules/interoperability/sidechain/commands/register_mainchain.ts

sitetester commented 11 months ago

@gkoumout FYI

shuse2 commented 9 months ago

Closing this issue for no activity

LiskArchive / lisk-sdk