Review usage of computeValidatorsHash and related unit tests

LiskArchive / lisk-sdk

🔩 Lisk software development kit

https://lisk.com

Apache License 2.0

2.72k stars 454 forks source link

Review usage of computeValidatorsHash and related unit tests #9084

Closed ishantiw closed 9 months ago

ishantiw commented 11 months ago

Description

Since the sorting of BLS keys is not happening within computeValidatorsHash, we need to make sure that we do sorting of validators before calling this function. Below are the occurrences and we should review unit tests

Review unit tests for following functions

verifyValidatorsUpdate
Register sidechain
Register mainchain
genesis_block.ts

Which version(s) does this affect? (Environment, OS, etc...)

v6.0.0-rc.3

shuse2 commented 9 months ago

Closing this issue for no activity