LiskArchive / lisk-sdk

🔩 Lisk software development kit
https://lisk.com
Apache License 2.0
2.72k stars 454 forks source link

When executeCommon fails it should fail the transaction instead of returning #9112

Closed ishantiw closed 11 months ago

ishantiw commented 11 months ago

Expected behavior

According to LIP0053, if executeCommon fails then it should fail the CCU transaction

Actual behavior

if executeCommon fails then it doesn't fail the transaction but instead of that it returns without error.

Steps to reproduce

Which version(s) does this affect? (Environment, OS, etc...)

6.0.0-rc.3