LiskArchive / lisk-sdk

🔩 Lisk software development kit
https://lisk.com
Apache License 2.0
2.72k stars 457 forks source link

Merge release/6.0.0 into release/6.1.0 #9123

Closed shuse2 closed 8 months ago

shuse2 commented 8 months ago

Description

Merge release/6.0.0 branch into release/6.1.0 branch

codecov[bot] commented 8 months ago

Codecov Report

Merging #9123 (dcb7d10) into release/6.1.0 (cf9caad) will decrease coverage by 0.04%. The diff coverage is 86.17%.

Impacted file tree graph

@@                Coverage Diff                @@
##           release/6.1.0    #9123      +/-   ##
=================================================
- Coverage          84.39%   84.35%   -0.04%     
=================================================
  Files                652      655       +3     
  Lines              23968    24137     +169     
  Branches            3489     3506      +17     
=================================================
+ Hits               20228    20361     +133     
- Misses              3740     3776      +36     
Files Coverage Δ
...ommander/src/bootstrapping/commands/keys/create.ts 100.00% <100.00%> (ø)
...der/src/bootstrapping/commands/transaction/sign.ts 93.05% <100.00%> (+0.95%) :arrow_up:
commander/test/helpers/account.ts 31.03% <100.00%> (+2.46%) :arrow_up:
elements/lisk-api-client/src/ipc_channel.ts 11.53% <100.00%> (ø)
elements/lisk-chain/src/block_header.ts 74.62% <100.00%> (ø)
elements/lisk-cryptography/src/encrypt.ts 97.22% <100.00%> (+0.02%) :arrow_up:
...ain-connector-plugin/src/certificate_generation.ts 97.95% <100.00%> (+0.04%) :arrow_up:
...ork-monitor-plugin/src/controllers/transactions.ts 22.22% <ø> (ø)
framework/src/application.ts 82.41% <100.00%> (ø)
framework/src/controller/constants.ts 100.00% <100.00%> (ø)
... and 63 more

... and 2 files with indirect coverage changes

sitetester commented 8 months ago

For mainchain, there are duplicated test cases in this PR, e.g., In 6.0, there is only usage for it('should call _verifyTerminatedStateAccountsIDs', (same for other tests).

For sidechain, it only shows inline changes, but if we compare this with 6.0, end line numbers don't match

shuse2 commented 8 months ago

@sitetester since this is merge PR, ill resolve the comments regarding the code change