LiskArchive / lisk-sdk

🔩 Lisk software development kit
https://lisk.com
Apache License 2.0
2.72k stars 457 forks source link

Updates unit tests; `ValidatorsMethod` #9126

Closed has5aan closed 8 months ago

has5aan commented 8 months ago

What was the problem?

This PR resolves issue #8115 & issue #7267 Some points in the issue, potentially requiring no change are responded to in a comment on the issue.

How was it solved?

Adds and updates tests for ValidatorsMethod.

How was it tested?

All tests are passing.

codecov[bot] commented 8 months ago

Codecov Report

Merging #9126 (a616525) into release/6.1.0 (223afce) will increase coverage by 0.04%. The diff coverage is n/a.

:exclamation: Current head a616525 differs from pull request most recent head 1429ec6. Consider uploading reports for the commit 1429ec6 to get more accurate results

Impacted file tree graph

@@                Coverage Diff                @@
##           release/6.1.0    #9126      +/-   ##
=================================================
+ Coverage          84.35%   84.39%   +0.04%     
=================================================
  Files                652      652              
  Lines              23970    23964       -6     
  Branches            3490     3488       -2     
=================================================
+ Hits               20219    20224       +5     
+ Misses              3751     3740      -11     
Files Coverage Δ
framework/src/modules/validators/method.ts 97.84% <ø> (+7.77%) :arrow_up:

... and 2 files with indirect coverage changes