LiskArchive / lisk-sdk

🔩 Lisk software development kit
https://lisk.com
Apache License 2.0
2.72k stars 457 forks source link

Make --chain-id flag consistent across commands #9131

Open przemerr opened 8 months ago

przemerr commented 8 months ago

Description

The --chainid in: lisk-core keys:create --chainid <value> --output <path> --add-legacy requires a decimal value of an actual chainid i.e if the chain ID is 99000000 you need to input 153

the --chain-id in: lisk-core transaction:create legacy registerKeys 10000000 --key-derivation-path=legacy --chain-id 99000000 --no-signature --sender-public-key=<pubkey> requires a full ID of the chain ie. if the chain ID is 99000000 you need to input 99000000

also one flag has a dash -, other doesn't

Motivation

To introduce less confusion, and avoid potential mistakes