LiskArchive / lisk-sdk

🔩 Lisk software development kit
https://lisk.com
Apache License 2.0
2.72k stars 454 forks source link

Multi-sig transactions execution fails. #9133

Closed TalhaMaliktz closed 9 months ago

TalhaMaliktz commented 11 months ago

Expected behavior

Once the transaction is posted to the node, it should be executed and the balance of both receiver and sender should updated accordingly.

Actual behavior

There is a case where the node accepts a fully signed multi-signature transaction, which dry runs successfully and is posted successfully to the node. but, the transaction never gets executed on the node. The balance of neither the recipient nor the sender gets updated and no error is shown in response to invoking the following endpoints:

txpool_dryRunTransaction

"result": {
    "result": 1,
    "events": [
        {
            "data": "0a14532b9298982fea2a84212af2ceed5b5230ddfefe12036665651a08000000010000000020c0843d2800",
            "index": 0,
            "module": "token",
            "name": "lock",
            "topics": [
                "0407763c8833eb3d2d3b3eaf69a060cae8308447a0731f35d75080b00599bf7b68",
                "532b9298982fea2a84212af2ceed5b5230ddfefe"
            ],
            "height": 14107
        },
        {
            "data": "0a14532b9298982fea2a84212af2ceed5b5230ddfefe1214f94b4fc46a71d7c913d89cbf30cc698f3ee3120d1a0800000001000000002080dac4092800",
            "index": 1,
            "module": "token",
            "name": "transfer",
            "topics": [
                "0407763c8833eb3d2d3b3eaf69a060cae8308447a0731f35d75080b00599bf7b68",
                "532b9298982fea2a84212af2ceed5b5230ddfefe",
                "f94b4fc46a71d7c913d89cbf30cc698f3ee3120d"
            ],
            "height": 14107
        },
        {
            "data": "0a14532b9298982fea2a84212af2ceed5b5230ddfefe12036665651a08000000010000000020c0843d2800",
            "index": 2,
            "module": "token",
            "name": "unlock",
            "topics": [
                "0407763c8833eb3d2d3b3eaf69a060cae8308447a0731f35d75080b00599bf7b68",
                "532b9298982fea2a84212af2ceed5b5230ddfefe"
            ],
            "height": 14107
        },
        {
            "data": "0a14532b9298982fea2a84212af2ceed5b5230ddfefe121401d50696a264a3ed30f903a2c9e2bd3b5a3756ee1a0800000001000000002090c12e2800",
            "index": 3,
            "module": "token",
            "name": "transfer",
            "topics": [
                "0407763c8833eb3d2d3b3eaf69a060cae8308447a0731f35d75080b00599bf7b68",
                "532b9298982fea2a84212af2ceed5b5230ddfefe",
                "01d50696a264a3ed30f903a2c9e2bd3b5a3756ee"
            ],
            "height": 14107
        },
        {
            "data": "0a14532b9298982fea2a84212af2ceed5b5230ddfefe1208000000010000000018b0c30e2000",
            "index": 4,
            "module": "token",
            "name": "burn",
            "topics": [
                "0407763c8833eb3d2d3b3eaf69a060cae8308447a0731f35d75080b00599bf7b68",
                "532b9298982fea2a84212af2ceed5b5230ddfefe"
            ],
            "height": 14107
        },
        {
            "data": "0a14532b9298982fea2a84212af2ceed5b5230ddfefe121401d50696a264a3ed30f903a2c9e2bd3b5a3756ee18b0c30e2090c12e",
            "index": 5,
            "module": "fee",
            "name": "generatorFeeProcessed",
            "topics": [
                "0407763c8833eb3d2d3b3eaf69a060cae8308447a0731f35d75080b00599bf7b68",
                "532b9298982fea2a84212af2ceed5b5230ddfefe",
                "01d50696a264a3ed30f903a2c9e2bd3b5a3756ee"
            ],
            "height": 14107
        },
        {
            "data": "0801",
            "index": 6,
            "module": "token",
            "name": "commandExecutionResult",
            "topics": [
                "0407763c8833eb3d2d3b3eaf69a060cae8308447a0731f35d75080b00599bf7b68"
            ],
            "height": 14107
        }
    ]
}

txpool_postTransaction

"result": {
    "transactionId": "07763c8833eb3d2d3b3eaf69a060cae8308447a0731f35d75080b00599bf7b68"
}

chain_getEvents

"result": [
    {
        "data": "08001001",
        "index": 0,
        "module": "dynamicReward",
        "name": "rewardMinted",
        "topics": [
            "03",
            "01d50696a264a3ed30f903a2c9e2bd3b5a3756ee"
        ],
        "height": 14108
    }
]

Steps to reproduce

Try this script, or use the CLI to create and sign a multi-sig token transfer transaction.

Which version(s) does this affect? (Environment, OS, etc...)

lisk-sdk": "6.0.0-rc.5

shuse2 commented 9 months ago

Closing this issue since this is no longer valid