search

LiskArchive / lisk-sdk

🔩 Lisk software development kit
https://lisk.com
Apache License 2.0
2.72k stars 454 forks source link

Add missing unit tests for certificate generation and commit pool #9145

Closed mitsuaki-u closed 10 months ago

mitsuaki-u commented 10 months ago

What was the problem?

This PR resolves #7949

How was it solved?

Some points from original audit are now outdated due to new logic. Incorrect test descriptions and parameters were updated as well as missing unit tests added.

How was it tested?

Added missing tests

codecov[bot] commented 10 months ago

Codecov Report

Merging #9145 (a885526) into release/6.1.0 (8c7aba6) will not change coverage. The diff coverage is n/a.

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/LiskHQ/lisk-sdk/pull/9145/graphs/tree.svg?width=650&height=150&src=pr&token=2JhT7caf5x&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=LiskHQ)](https://app.codecov.io/gh/LiskHQ/lisk-sdk/pull/9145?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=LiskHQ) ```diff @@ Coverage Diff @@ ## release/6.1.0 #9145 +/- ## ============================================== Coverage 84.35% 84.35% ============================================== Files 655 655 Lines 24113 24113 Branches 3497 3497 ============================================== Hits 20340 20340 Misses 3773 3773 ```
mitsuaki-u commented 10 months ago

Some cosmetic changes were left as is for better clarity