search

LiskArchive / lisk-sdk

🔩 Lisk software development kit
https://lisk.com
Apache License 2.0
2.72k stars 457 forks source link

Fix config on application bootstrap #9152

Closed ishantiw closed 7 months ago

ishantiw commented 7 months ago

What was the problem?

This PR resolves #9151

How was it solved?

How was it tested?

In order to test locally,

  1. build commander
  2. yarn link
  3. npm i -g
  4. ./bin/run init ~/Desktop/testapp
  5. cd ~/Desktop/testapp
  6. yarn link lisk-commander
  7. ./bin/run config:create --chain-id 02000001 --label 'testapp'
  8. check the config.json file for dataPath and rpc values
codecov[bot] commented 7 months ago

Codecov Report

Merging #9152 (40e6c38) into hotfix/6.0.1 (1e73f05) will increase coverage by 0.83%. The diff coverage is 0.00%.

:exclamation: Current head 40e6c38 differs from pull request most recent head aa5803c. Consider uploading reports for the commit aa5803c to get more accurate results

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/LiskHQ/lisk-sdk/pull/9152/graphs/tree.svg?width=650&height=150&src=pr&token=2JhT7caf5x&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=LiskHQ)](https://app.codecov.io/gh/LiskHQ/lisk-sdk/pull/9152?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=LiskHQ) ```diff @@ Coverage Diff @@ ## hotfix/6.0.1 #9152 +/- ## ================================================ + Coverage 83.52% 84.35% +0.83% ================================================ Files 606 655 +49 Lines 22826 24111 +1285 Branches 3364 3489 +125 ================================================ + Hits 19065 20340 +1275 - Misses 3761 3771 +10 ``` | [Files](https://app.codecov.io/gh/LiskHQ/lisk-sdk/pull/9152?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=LiskHQ) | Coverage Δ | | |---|---|---| | [commander/src/utils/config.ts](https://app.codecov.io/gh/LiskHQ/lisk-sdk/pull/9152?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=LiskHQ#diff-Y29tbWFuZGVyL3NyYy91dGlscy9jb25maWcudHM=) | `100.00% <ø> (ø)` | | | [...mander/src/bootstrapping/commands/config/create.ts](https://app.codecov.io/gh/LiskHQ/lisk-sdk/pull/9152?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=LiskHQ#diff-Y29tbWFuZGVyL3NyYy9ib290c3RyYXBwaW5nL2NvbW1hbmRzL2NvbmZpZy9jcmVhdGUudHM=) | `34.37% <0.00%> (-1.99%)` | :arrow_down: | ... and [99 files with indirect coverage changes](https://app.codecov.io/gh/LiskHQ/lisk-sdk/pull/9152/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=LiskHQ)