search

LiskArchive / lisk-sdk

🔩 Lisk software development kit
https://lisk.com
Apache License 2.0
2.72k stars 457 forks source link

Update Default CCU Fee #9153

Closed Phanco closed 7 months ago

Phanco commented 7 months ago

What was the problem?

This PR resolves #9147

How was it solved?

  1. Updated ccuFee to 0 as default
  2. When ccuFee is 0, computeMinFee is used
  3. All examples and test have suggested 500000 fee

How was it tested?

Test cases added

codecov[bot] commented 7 months ago

Codecov Report

Merging #9153 (e6a7c5d) into hotfix/6.0.1 (f825978) will increase coverage by 0.01%. Report is 1 commits behind head on hotfix/6.0.1. The diff coverage is 100.00%.

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/LiskHQ/lisk-sdk/pull/9153/graphs/tree.svg?width=650&height=150&src=pr&token=2JhT7caf5x&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=LiskHQ)](https://app.codecov.io/gh/LiskHQ/lisk-sdk/pull/9153?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=LiskHQ) ```diff @@ Coverage Diff @@ ## hotfix/6.0.1 #9153 +/- ## ================================================ + Coverage 83.51% 83.53% +0.01% ================================================ Files 606 606 Lines 22826 22839 +13 Branches 3364 3367 +3 ================================================ + Hits 19064 19078 +14 + Misses 3762 3761 -1 ``` | [Files](https://app.codecov.io/gh/LiskHQ/lisk-sdk/pull/9153?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=LiskHQ) | Coverage Δ | | |---|---|---| | [...nder/src/bootstrapping/commands/blockchain/hash.ts](https://app.codecov.io/gh/LiskHQ/lisk-sdk/pull/9153?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=LiskHQ#diff-Y29tbWFuZGVyL3NyYy9ib290c3RyYXBwaW5nL2NvbW1hbmRzL2Jsb2NrY2hhaW4vaGFzaC50cw==) | `94.28% <100.00%> (+0.16%)` | :arrow_up: | | [...ain-connector-plugin/src/chain\_connector\_plugin.ts](https://app.codecov.io/gh/LiskHQ/lisk-sdk/pull/9153?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=LiskHQ#diff-ZnJhbWV3b3JrLXBsdWdpbnMvbGlzay1mcmFtZXdvcmstY2hhaW4tY29ubmVjdG9yLXBsdWdpbi9zcmMvY2hhaW5fY29ubmVjdG9yX3BsdWdpbi50cw==) | `79.00% <100.00%> (+0.76%)` | :arrow_up: | | [...sk-framework-chain-connector-plugin/src/schemas.ts](https://app.codecov.io/gh/LiskHQ/lisk-sdk/pull/9153?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=LiskHQ#diff-ZnJhbWV3b3JrLXBsdWdpbnMvbGlzay1mcmFtZXdvcmstY2hhaW4tY29ubmVjdG9yLXBsdWdpbi9zcmMvc2NoZW1hcy50cw==) | `100.00% <ø> (ø)` | | ... and [1 file with indirect coverage changes](https://app.codecov.io/gh/LiskHQ/lisk-sdk/pull/9153/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=LiskHQ)