LiskArchive / lisk-sdk

🔩 Lisk software development kit
https://lisk.com
Apache License 2.0
2.72k stars 457 forks source link

Add StateMachine Lock #9172

Closed Phanco closed 5 months ago

Phanco commented 7 months ago

What was the problem?

This PR resolves #8353

How was it solved?

How was it tested?

codecov[bot] commented 7 months ago

Codecov Report

Merging #9172 (bdb4223) into release/6.1.0 (175f817) will decrease coverage by 0.01%. The diff coverage is 64.28%.

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/LiskHQ/lisk-sdk/pull/9172/graphs/tree.svg?width=650&height=150&src=pr&token=2JhT7caf5x&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=LiskHQ)](https://app.codecov.io/gh/LiskHQ/lisk-sdk/pull/9172?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=LiskHQ) ```diff @@ Coverage Diff @@ ## release/6.1.0 #9172 +/- ## ================================================= - Coverage 84.36% 84.35% -0.01% ================================================= Files 655 655 Lines 24113 24123 +10 Branches 3497 3498 +1 ================================================= + Hits 20343 20350 +7 - Misses 3770 3773 +3 ``` | [Files](https://app.codecov.io/gh/LiskHQ/lisk-sdk/pull/9172?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=LiskHQ) | Coverage Δ | | |---|---|---| | [...ents/lisk-transaction-pool/src/transaction\_pool.ts](https://app.codecov.io/gh/LiskHQ/lisk-sdk/pull/9172?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=LiskHQ#diff-ZWxlbWVudHMvbGlzay10cmFuc2FjdGlvbi1wb29sL3NyYy90cmFuc2FjdGlvbl9wb29sLnRz) | `90.67% <100.00%> (+0.14%)` | :arrow_up: | | [framework/src/application.ts](https://app.codecov.io/gh/LiskHQ/lisk-sdk/pull/9172?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=LiskHQ#diff-ZnJhbWV3b3JrL3NyYy9hcHBsaWNhdGlvbi50cw==) | `82.41% <100.00%> (ø)` | | | [framework/src/engine/engine.ts](https://app.codecov.io/gh/LiskHQ/lisk-sdk/pull/9172?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=LiskHQ#diff-ZnJhbWV3b3JrL3NyYy9lbmdpbmUvZW5naW5lLnRz) | `70.90% <100.00%> (+0.17%)` | :arrow_up: | | [framework/src/engine/generator/generator.ts](https://app.codecov.io/gh/LiskHQ/lisk-sdk/pull/9172?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=LiskHQ#diff-ZnJhbWV3b3JrL3NyYy9lbmdpbmUvZ2VuZXJhdG9yL2dlbmVyYXRvci50cw==) | `81.88% <ø> (ø)` | | | [framework/src/testing/block\_processing\_env.ts](https://app.codecov.io/gh/LiskHQ/lisk-sdk/pull/9172?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=LiskHQ#diff-ZnJhbWV3b3JrL3NyYy90ZXN0aW5nL2Jsb2NrX3Byb2Nlc3NpbmdfZW52LnRz) | `18.45% <0.00%> (ø)` | | | [framework/src/engine\_igniter.ts](https://app.codecov.io/gh/LiskHQ/lisk-sdk/pull/9172?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=LiskHQ#diff-ZnJhbWV3b3JrL3NyYy9lbmdpbmVfaWduaXRlci50cw==) | `0.00% <0.00%> (ø)` | | | [framework/src/state\_machine/state\_machine.ts](https://app.codecov.io/gh/LiskHQ/lisk-sdk/pull/9172?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=LiskHQ#diff-ZnJhbWV3b3JrL3NyYy9zdGF0ZV9tYWNoaW5lL3N0YXRlX21hY2hpbmUudHM=) | `87.42% <60.00%> (-0.81%)` | :arrow_down: |
ishantiw commented 5 months ago

Closing the PR and the issue will be revisited in future