search

LiskArchive / lisk-ui

🖥️ Lisk user-interface submodule
https://lisk.io/
GNU General Public License v3.0
24 stars 35 forks source link

More effective forging controller #108

Closed toschdev closed 7 years ago

toschdev commented 7 years ago

Current behaviour: The forging controller makes 4 API calls, with today, 1 day, 7 days and 30 days. https://github.com/LiskHQ/lisk-ui/blob/development/js/controllers/forgingController.js#L182

Expected behaviour: The forging controller makes 1 API call (30 days) and from there can substract from the given array the days (by timestamp).

Is that possible?

Isabello commented 7 years ago

The amount forged may vary from the 30 day amount due to fees and missed blocks. So while it would provide a brief overview, it won't be as accurate as users might want.

On Wed, Mar 22, 2017 at 10:48 AM, Tobias Schwarz notifications@github.com wrote:

Current behaviour: The forging controller makes 4 API calls, with today, 1 day, 7 days and 30 days. https://github.com/LiskHQ/lisk-ui/blob/development/js/ controllers/forgingController.js#L182

Expected behaviour: The forging controller makes 1 API call (30 days) and from there can substract from the given array the days (by timestamp).

Is that possible?

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/LiskHQ/lisk-ui/issues/108, or mute the thread https://github.com/notifications/unsubscribe-auth/APzFsFQRk44QOv94Lm7Rdpw1emYxe3qzks5roULSgaJpZM4MlaVv .

toschdev commented 7 years ago

Thanks for the insights Isabella.