LiskArchive / lisk-ui

🖥️ Lisk user-interface submodule
https://lisk.io/
GNU General Public License v3.0
24 stars 35 forks source link

Reference to USD should be replaced with BTC or removed completely #44

Open qtipwax opened 8 years ago

qtipwax commented 8 years ago

I would like the reference to USD removed. It is biased towards one country and cypto should try to move away from fiat references when possible. Possible solutions.

1) Replaced with BTC value would be more appropriate in my opinion. 2) If not all languages that Lisk supports should have their currency listed. 3) References to other fiat or crypto removed completely.

qtipwax commented 8 years ago
usd
densmirnov commented 8 years ago

I disagree. First of all, the ability to know the value of your assets without accessing the exchange is very handy. Second, USD is like universal standard for crypto accepted by everyone no matter what country are you from. Just as Bitcoin. Rather, I would add an option to select which currency you prefer to see. But in any case, it wouldn't remove it.

mrv777 commented 8 years ago

Looks like you could change:

$scope.convertToUSD = function (lisk) {
        return (lisk / 100000000) * $scope.lisk_usd;
    };

to something like this to get the new value:

$scope.convertToUSD = function (lisk) {
        if (someSetting=='btc')
                return (lisk / 100000000) * $scope.lisk_btc;
        else
                return (lisk / 100000000) * $scope.lisk_usd;
    };

Would also need to update these with an if statement to make it obvious it is BTC and not USD now: partials/modals/userInfo.html partials/modals/transactionInfo.html partials/modals/blockInfo.html

qtipwax commented 8 years ago

My issue with USD is that I need to convert it again into the "local" currency whether Chinese Yuan, Korean Won, Euro, Krone, Rupee, etc. If using BTC there is only one conversion and I know the value.

fix commented 8 years ago

Closing it as won't fix, what do you think @karmacoma ?