LiskHQ / lisk-desktop

🖥 Lisk graphical user interface for desktop
https://lisk.com/wallet
GNU General Public License v3.0
578 stars 96 forks source link

Improve Icon component and use it everywhere #2098

Closed slaweet closed 5 years ago

slaweet commented 5 years ago

Current behavior

$ git grep 'utils/svgIcons'
src/components/accountVisual/index.js:import svg from '../../utils/svgIcons';
src/components/bookmark/bookmark.js:import svg from '../../utils/svgIcons';
src/components/bookmarkV2/index.js:import svg from '../../utils/svgIcons';
src/components/dashboardV2/recentTransactions/recentTransactions.js:import svg from '../../../utils/svgIcons';
src/components/delegatesListView/voteCheckboxV2.js:import svgIcons from '../../utils/svgIcons';
src/components/headerV2/headerV2.js:import svg from '../../utils/svgIcons';
src/components/hwWalletLogin/loadingIcon.js:import svgIcons from '../../utils/svgIcons';
src/components/hwWalletLogin/selectAccount/accountCard.js:import svg from '../../../utils/svgIcons';
src/components/hwWalletLogin/selectDevice.js:import svgIcons from '../../utils/svgIcons';
src/components/newsFeedV2/news.js:import svg from '../../utils/svgIcons';
src/components/registerV2/backupPassphrase.js:import svgIcons from '../../utils/svgIcons';
src/components/requestV2/requestV2.js:import svg from '../../utils/svgIcons';
src/components/searchBarV2/transactions.js:import svg from '../../utils/svgIcons';
src/components/sendV2/form/form.js:import svg from '../../../utils/svgIcons';
src/components/sendV2/transactionStatus/statusMessages.js:import svg from '../../../utils/svgIcons';
src/components/singleTransactionV2/singleTransactionV2.js:import svg from '../../utils/svgIcons';
src/components/statusBar/statusBar.js:import svg from '../../utils/svgIcons';
src/components/toolbox/calendar/monthView.js:import svg from '../../../utils/svgIcons';
src/components/toolbox/calendar/yearView.js:import svg from '../../../utils/svgIcons';
src/components/toolbox/checkBox/index.js:import svgIcons from '../../../utils/svgIcons';
src/components/toolbox/feedback/feedback.js:import svg from '../../../utils/svgIcons';
src/components/topBar/constants.js:import svg from '../../utils/svgIcons';
src/components/topBar/navigationButtons.js:import svg from '../../utils/svgIcons';
src/components/topBar/topBar.js:import svg from '../../utils/svgIcons';
src/components/transactions/typeFigure/TransactionTypeFigure.js:import svg from '../../../utils/svgIcons';
src/components/transactionsV2/filters/amountFieldGroup.js:import svg from '../../../utils/svgIcons';
src/components/transactionsV2/filters/dateFieldGroup.js:import svg from '../../../utils/svgIcons';
src/components/transactionsV2/filters/filterContainer.js:import svg from '../../../utils/svgIcons';
src/components/transactionsV2/filters/messageFieldGroup.js:import svg from '../../../utils/svgIcons';
src/components/transactionsV2/transactionTypeV2.js:import svg from '../../utils/svgIcons';
src/components/wallet/walletDetails.js:import svg from '../../utils/svgIcons';

Expected behavior

reyraa commented 5 years ago

In order to simplify the icon design process and have a shared set of icons between Mobile and Hub, I'd like to change this slightly to use font icons. I've already requested designers to change the icons.