LiskHQ / lisk-desktop

🖥 Lisk graphical user interface for desktop
https://lisk.com/wallet
GNU General Public License v3.0
580 stars 95 forks source link

Unable to send a transaction from a specific multisignature account #4141

Closed przemerr closed 2 years ago

przemerr commented 2 years ago

Expected behavior

User should be able to send a transaction from any multisignature account

Actual behavior

User is unable to send a transfer transaction from a multisingature account that has one required key that doesn't belong to senders account (example of the account https://testnet-service.lisk.io/api/v2/accounts?address=lsko3qy92jx8g9h4zhghdbey6n753k434wmpeoeaw)

Steps to reproduce

Create a multisignature account with one required key that doesn't belong to senders account (example https://testnet-service.lisk.io/api/v2/accounts?address=lsko3qy92jx8g9h4zhghdbey6n753k434wmpeoeaw). After creating it, try sending a transfer transaction with the account

Which version(s) does this affect? (Environment, OS, etc...)

Windows Lisk Desktop 2.2.0, doesn't affect 2.1.0.

ManuGowda commented 2 years ago

While sign and send, the below screen appears.

Screenshot 2022-02-03 at 2 04 06 PM
reyraa commented 2 years ago

@ManuGowda This account is impractical and with the current validations of the multisig registration form, you shouldn't be able to create such accounts.

We talked about this a couple of times and decided not to support such accounts.

Nonetheless, if there's an explainable use case for a multisig account with a single member, we can go ahead and make Lisk Desktop accept such accounts. In such case, we should update the multisig registration form validation to accept accounts with a single member.

przemerr commented 2 years ago

@reyraa There are users that have this type of account (mainly by mistake), and you can register those type of accounts in 2.2.0 image

the sending from those accounts worked in 2.1.0

przemerr commented 2 years ago

they are still somewhat useful if you're a delegate, since you sign blocks with your delegate account, and send tokens with the other signature.

reyraa commented 2 years ago

Yes, this is a limited yet valid use case. Thanks.