LiskHQ / lisk-desktop

🖥 Lisk graphical user interface for desktop
https://lisk.com/wallet
GNU General Public License v3.0
581 stars 96 forks source link

Fix wallet connect signing on different chain #5549

Closed ikem-legend closed 8 months ago

ikem-legend commented 9 months ago

What was the problem?

This PR resolves #5508

How was it solved?

How was it tested?

ikem-legend commented 8 months ago
image

I think if it would be nice if we can direct users to which network/application they should switch to

While we can know the application the user initiated the transaction with, without changing the current WalletConnect setup, we have no means of knowing the network. Some applications also have the same name in different networks, only differentiator is chainID. So in such cases, if we tried to display the application to be switched to, the user would see an error message like Please switch application to lisk_mainchain and that would be confusing if they're on lisk_mainchain but on a different network

CLAassistant commented 8 months ago

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.