Lisp-Stat / data-frame

Data frames for Common Lisp
https://lisp-stat.github.io/data-frame
Microsoft Public License
28 stars 4 forks source link

Upgrade to clunit2 #9

Closed Symbolics closed 2 years ago

Symbolics commented 3 years ago

clunit is abandoned, and clunit2 its replacement. When testing under clunit2, the deffixture is broken and many of the tests fail because the variables define there do not exist.

cage2 commented 2 years ago

Hi!

You was right that deffixture was broken, i tried to fix it and i believe the test should pass now using the suite from the git repository¹ (i have actually tried :-)) with two caveats:

The second point seems more important that the first but i can not actually be sure about that as i do not use this code, so i let you decide if my message can be considered a solution for this issue or not. ;-D

Bye and thank you for pointing out the problem with deffixture! C.

¹ https://notabug.org/cage/clunit2

snunez1 commented 2 years ago

Thank you. For me, on SBCL 2.1, the tests compiled with the pprint functions for arrays. I think the warnings are normal; the fixtures define several variables for use in a suite of tests, and not every testing within the suite uses all of the variables that are defined. The warnings can be ignored.

cage2 commented 2 years ago

Hi!

Thank you.

You're welcome! :)

For me, on SBCL 2.1, the tests compiled with the pprint functions for arrays.

I am using SBCL 2.1.9, are you using the same or older?

[...] The warnings can be ignored.

Very well! :+1: Bye! C.