search

Lissy93 / dashy

🚀 A self-hostable personal dashboard built for you. Includes status-checking, widgets, themes, icon packs, a UI editor and tons more!
https://dashy.to
MIT License
16.77k stars 1.28k forks source link

[FEATURE_REQUEST] Unify weather and weather forecast widgets #1475

Open bogdanjsx opened 6 months ago

bogdanjsx commented 6 months ago

Is your feature request related to a problem? If so, please describe.

Hi! I started using the weather forecast widget and it behaves a bit strangely - see image.

image

I checked the response from the openweathermap API and it looks like for the forecast the increment is 3 hours, not 1 day. That's probably why the same day gets shown 5 times in my case.

Describe the solution you'd like

Openweathermap migrated to One Call API 3.0, which is also free for <1000 calls/day (more than enough for a regular user), so I think Dashy should, as well.

As an improvement, since the new API returns both current weather and forecast in multiple time period steps, in my opinion the best solution would be to have a single weather widget which can display any type of forecast(hourly/daily/none) based on config. This also avoids a double call to the API if a user wants all of this info - right now the only option would be having both widgets.

Priority

Medium (Would be very useful)

Is this something you would be keen to implement

None

liss-bot commented 6 months ago

If you're enjoying Dashy, consider dropping us a ⭐
🤖 I'm a bot, and this message was automated

bogdanjsx commented 6 months ago

Just checked the open issues and this is probably a duplicate of #1376.

Lissy93 commented 6 months ago

Hey @bogdanjsx. Re the incorrect dates, yeah that's a dup of #1376 - But your insight (3 hour increments) is the cause, so thank you for finding that!

In terms of combining the weather + weather forecast widgets, there have been some other tickets relating to the weather widget, and the API and endpoints used. The solution to which is probably going to be re-writing the weather widgets, at which point I'll look into combining current + foretasted weather.

I'm going to find those other tickets and reference/link to your ticket, and then close this issue, just to reduce clutter.

CrazyWolf13 commented 5 months ago

Spent hours, till I finally found out it was the api's fault and time was 3 hour increment -> https://github.com/Lissy93/dashy/issues/1376#issuecomment-1975280698 👍 @Lissy93
If you plan to fully rewrite it, then i'll probably not make any PR's to this.

CrazyWolf13 commented 5 months ago

Also linking #903 to here.