Lissy93 / dashy

🚀 A self-hostable personal dashboard built for you. Includes status-checking, widgets, themes, icon packs, a UI editor and tons more!
https://dashy.to
MIT License
17.07k stars 1.31k forks source link

:bug: On branch BUG/1608_glances-network-error #1646

Closed hockwill closed 1 month ago

hockwill commented 2 months ago

hockwill Quick hockwill /BUG/1608_glances-network-error → Lissy93/dashy Commits: 2 | Files Changed: 2 | Additions: 0 Label Powered by Pull Request Badge

Category: BUGFIX

Overview Glances Widgets for Network Traffic and Interfaces were not correctly displaying information provided from the api response.

Issue Number #1608

Code Quality Checklist (Please complete)

netlify[bot] commented 2 months ago

Deploy Preview for dashy-dev ready!

Name Link
Latest commit 12e3dbe9f4658dba07f4529ff463287da9a17831
Latest deploy log https://app.netlify.com/sites/dashy-dev/deploys/66c9b9b1eac958000896dc29
Deploy Preview https://deploy-preview-1646--dashy-dev.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

CrazyWolf13 commented 1 month ago

Fixes #1608 and #1594 🚀

hockwill commented 1 month ago

I can look again later this week at the ip plugin. I suspect it is a similar problem in that the fields returned have changed names.

On Wed, Aug 7, 2024, 07:03 Tobias @.***> wrote:

Fixes #1608 https://github.com/Lissy93/dashy/issues/1608 and #1594 https://github.com/Lissy93/dashy/issues/1594 🚀

— Reply to this email directly, view it on GitHub https://github.com/Lissy93/dashy/pull/1646#issuecomment-2273205918, or unsubscribe https://github.com/notifications/unsubscribe-auth/AX7BZ24S3HGHMR3UGWZB2G3ZQH5JRAVCNFSM6AAAAABLHN4U2KVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDENZTGIYDKOJRHA . You are receiving this because you authored the thread.Message ID: @.***>

hockwill commented 1 month ago

Awesome, just tested and all plugins except the IP plugin seems to work, (the IP plugin shows a message that the glances version is not compatible with that plugin)

The glances gl-ip-address widget seems to work with no errors? Where is the version error message?

hockwill commented 1 month ago

I see this was approved a bit ago. Is there something else I need to do that I have not done? Sorry for the close/open. I was seeing if it was something I needed to press.

CrazyWolf13 commented 1 month ago

Yes, a merge was needed :).