search

Lissy93 / dashy

🚀 A self-hostable personal dashboard built for you. Includes status-checking, widgets, themes, icon packs, a UI editor and tons more!
https://dashy.to
MIT License
18.22k stars 1.38k forks source link

[BUG] Section still visible while searching, even when no results #447

Closed Lissy93 closed 2 years ago

Lissy93 commented 2 years ago

Raised by @kimpenhaus in https://github.com/Lissy93/dashy/discussions/444

Originally posted by **kimpenhaus** January 25, 2022 Hi, there seems to be a change lately which shows a 'no items to show yet' label in empty, expanded container with no elements. Before those container were hidden - is there any config prop to enable the old behavior again? Thanks, m. image

Probably Cause

The no-results class is being correctly applied

https://github.com/Lissy93/dashy/blob/5f8a83fd4782ce72b86fc6354eb7beee2521f594/src/views/Home.vue#L45-L46

But the CSS that hides the section doesn't seem to have any effect:

https://github.com/Lissy93/dashy/blob/5f8a83fd4782ce72b86fc6354eb7beee2521f594/src/views/Home.vue#L262-L263

kimpenhaus commented 2 years ago

Thank you!

kimpenhaus commented 2 years ago

Looks to be good with the latest docker version! Thanks for the quick fix!

liss-bot commented 2 years ago

The fix for this issue has now been released in Dashy 2.0.0 ✨

If you haven't done so already, please update your instance to 2.0.0 or later. See Dashy 2.0.0 for full info.

Feel free to reach out if you need any more support. If you are enjoying Dashy, consider supporting the project.