Lissy93 / dashy

🚀 A self-hostable personal dashboard built for you. Includes status-checking, widgets, themes, icon packs, a UI editor and tons more!
https://dashy.to
MIT License
18.22k stars 1.38k forks source link

cutToHeight does not work #461

Closed MihataBG closed 2 years ago

MihataBG commented 2 years ago

Environment

Self-Hosted (Docker)

Version

2.0.0

Describe the problem

When we set cutToHeight: true, it does not work also go to error in configuration editor: cutToHeight

Additional info

Theme is "Colorful"

Please tick the boxes

MihataBG commented 2 years ago

To resolve the error messages cutToHeight has to be added to ConfigSchema.json?

Lissy93 commented 2 years ago

Your right, looks like I forgot to add this to ConfigSchema.json.

I'll get that fixed this evening

MihataBG commented 2 years ago

Its so good, but this does not resolve the problem with "colorful" theme.

Lissy93 commented 2 years ago

Ah yeah, that seems to be caused by this line within the colourful theme block. https://github.com/Lissy93/dashy/blob/e1a78db85320bd3def159c9e82261ae725294129/src/styles/color-themes.scss#L356-L358

I'll add that to the fix too :)

Lissy93 commented 2 years ago

Forgot to say, but this was fixed in https://github.com/Lissy93/dashy/pull/462