search

Lissy93 / dashy

🚀 A self-hostable personal dashboard built for you. Includes status-checking, widgets, themes, icon packs, a UI editor and tons more!
https://dashy.to
MIT License
18.22k stars 1.38k forks source link

[FEEDBACK] Allow useProxy: true to be a global widget setting #486

Closed epheterson closed 2 years ago

epheterson commented 2 years ago

I'm getting into widgets now, and they had an issue connecting when on my reverse proxy, but worked fine when directly going to the port. I saw in troubleshooting this can be solved with useProxy: true, which did resolve my issue. I'm now copy/pasting it to all of my widgets which pull from self-hosted services.

It'd be nice if useProxy: true could be a global widget setting so I don't need to copy it on each widget, since my configuration seems to require it on all.

I guess external widgets may not require it, not sure if there's fallout of this being set on those as well?

Lissy93 commented 2 years ago

Sure, you should be able to do this with YAML Anchors, to define a property / set of properties once, then reuse them across as many items as you like.

Worth noting that a better solution would be to set the correct headers in your reverse proxy, to accept requests coming from the URL where you're hosting Dashy. Obviously that won't work for managed services, so for those you'll have to use the useProxy option.

In the meantime, I can add this option in to the global appConfig, although not sure if it's the best approach.

If you're running a fork of Dashy, and want to add in any more options to the config, then here is a guide on how to do so :)

epheterson commented 2 years ago

Thanks for all the info! Looking forward to the patch, it's probably the path I'll take.

Lissy93 commented 2 years ago

Implemented in #488 (released in V2.0.3) :)

epheterson commented 2 years ago

Works great, thanks!