search

Lissy93 / dashy

🚀 A self-hostable personal dashboard built for you. Includes status-checking, widgets, themes, icon packs, a UI editor and tons more!
https://dashy.to
MIT License
18.23k stars 1.38k forks source link

[FEATURE_REQUEST] allow toggle fullscreen for iframes in workspace view #524

Closed Byolock closed 2 years ago

Byolock commented 2 years ago

Is your feature request related to a problem? If so, please describe.

Toggle fullscreen buttons currently don't work in workspace view because iframes need to have <iframe allow="fullscreen"></iframe> set.

Describe the solution you'd like

Set allow="fullscreen" globally for dashy, or if there are any drawbacks that im not aware of providing it as an optional setting would be great

Priority

Medium (Would be very useful)

Is this something you would be keen to implement

No

Lissy93 commented 2 years ago

Sure, good idea - will look into this and hopefully get a PR submitted this week :)

And thank you so much for the sponsorship 💖

Lissy93 commented 2 years ago

Apologies again for the delay, have had a lot on. This has now been implemented in #557 :)