[BUG] Configuration not saveable when a single tag exists

[frankcai]

Environment

Self-Hosted (Docker)

Version

2.0.5

Describe the problem

This error is similar to #430 though not quite the same. In some cases when theres a single tag set in an item saving doesn't work. Further below i've described cases where it works and doesn't work.

In the console there is the following error when trying to save:

Test cases that fail to save:

• Add a tag "test" to an item, save and reopen then try to change any other field and save
• "test" Tag already exists, try to change any other field and save

Test cases that work:

• Add a tag "test" to an item and save
• Add a tag "test" to an item, change any other field and save
• Remove the "test" tag and save
• Remove the "test" tag, change any other field and save

Additional info

No response

Please tick the boxes

• [X] You are using a supported version of Dashy (check the first two digits of the version number)
• [X] You've checked that this issue hasn't already been raised
• [X] You've checked the docs and troubleshooting guide
• [X] You agree to the code of conduct

[Lissy93]

Thanks for the really clear test cases.

Looks like a type error, after the second save the tags are an array, so str.split is throwing an error.

https://github.com/Lissy93/dashy/blob/b51935f04976a56a27ecd3cd3124766f7148bfd0/src/components/InteractiveEditor/EditItem.vue#L234-L237

So I something like this should work

const strToTags = (str) => { 
- const tagArr = str.split(','); 
+ const tagArr = (typeof tags === 'string') ? tags.split(',') : tags;
  return tagArr.map((tag) => tag.trim().toLowerCase().replace(/[^a-z0-9]+/, '')); 
}; 

I'll test it out, and will submit a fix for this as part of #557 and update you when mreged.