search

Lissy93 / portainer-templates

🚢 500+ 1-click Portainer app templates
https://portainer-templates.as93.net
MIT License
1.83k stars 176 forks source link

feat: normalize casing of categories for each of the templates #29

Closed shmolf closed 6 months ago

shmolf commented 8 months ago

The main purpose of this PR, is to normalize the casing (upper/lower case) of the different categories, so that regardless of what convention the external repository uses, this aggregation will be consistent.

Addressing https://github.com/Lissy93/portainer-templates/issues/17

While QA'ing the changes locally, I saw the validate.py would fail because the Bookstack template was missing the image property.

Validation error: 'image' is a required property
Title of invalid template: Bookstack

This was not obvious as to who the offending template was, so I made a minor change to more easily identify which template caused the issue.

shmolf commented 6 months ago

@Lissy93 Is this PR acceptable?

If not, I'm fine just closing it.