search

Lissy93 / web-check

🕵️‍♂️ All-in-one OSINT tool for analysing any website
https://web-check.xyz
MIT License
20.76k stars 1.53k forks source link

CICD: bumped GHA versions #145

Closed vitalykarasik closed 1 month ago

vitalykarasik commented 1 month ago

Updated GitHub Actions versions (current versions use outdated Node runtime and other deprecated features)

netlify[bot] commented 1 month ago

Deploy Preview for web-check ready!

Built without sensitive environment variables

Name Link
Latest commit 17696d80cc2e5d4fead471e7912b56450831c253
Latest deploy log https://app.netlify.com/sites/web-check/deploys/6650083bc520bf0008f3a365
Deploy Preview https://deploy-preview-145--web-check.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

vitalykarasik commented 1 month ago

Thanks @vitalykarasik Just testing atm, did you verify these all worked, as it looks like some of those (like docker/build-push-action) had API changes the affect which parameters are needed?

@Lissy93 - To say the truth I didn't test end-to-end because it's tricky without your credentials. At a glance, it seems that there are no breaking changes. If you agree, I'll add a new trigger to https://github.com/Lissy93/web-check/blob/master/.github/workflows/docker.yml to activate this workflow on PR to master, not only on push - for test e2e. Please suggest.

vitalykarasik commented 1 month ago

I've tested locally, and it seems to be working, I'll go ahead and merge and watch closely to make sure it all still works.

Thanks again @vitalykarasik - appreciate your PR :)

Thank you! Please ping me if you see any issues with CI/CD or want to improve it.

vitalykarasik commented 1 month ago

I suspect we should revert - I see a few issues with the latest runs. @Lissy93

chrnorm/deployment-status@ - probably related to upgrade

node16 deprecation during "aws deploy" - I'm not sure why, node16 is still supported for a 2 weeks - https://docs.aws.amazon.com/lambda/latest/dg/lambda-nodejs.html