Open pauljmartinez opened 4 months ago
Built without sensitive environment variables
Name | Link |
---|---|
Latest commit | d738aafa1183abd979b3b98896c37bb3e75d20f7 |
Latest deploy log | https://app.netlify.com/sites/web-check/deploys/65e230fdefa88c0008240efd |
Deploy Preview | https://deploy-preview-99--web-check.netlify.app/ |
Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify site configuration.
Totally not necessary and I'd be happy to resubmit without making that change!
I'm unable to tell if that key I generated at https://developers.google.com/speed/docs/insights/v5/get-started is able to be used by the Google Safe Browsing service though.
I'm unable to tell if that key I generated at https://developers.google.com/speed/docs/insights/v5/get-started is able to be used by the Google Safe Browsing service though.
It's the same key, but you need to enable the safe browsing API in the Google dev dashboard
This PR attempts to resolve #10; however, I only just started using Web-Check and this may not be the preferred approach. That said, Iām happy to incorporate any feedback to make this PR more useful. :)
One unresolved issue is related to
api/threats.js
which appears to indicate thatGOOGLE_CLOUD_API_KEY
may be intended to work for both Page Speed Insights (Lighthouse) and Google Safe Browsing. Any clarification here would be greatly appreciated.The gist of this update is to rename the API key environment variable and to provide a more direct URL to assist users with adding support for the Quality Summary section of the report.
Additionally, this may introduce a breaking change for current users as they would need to modify their environment variables. Iām not sure how to best handle this type of situation.