Lissy93 / web-check

šŸ•µļøā€ā™‚ļø All-in-one OSINT tool for analysing any website
https://web-check.xyz
MIT License
20.95k stars 1.56k forks source link

Improve Quality Summary #99

Open pauljmartinez opened 4 months ago

pauljmartinez commented 4 months ago

This PR attempts to resolve #10; however, I only just started using Web-Check and this may not be the preferred approach. That said, Iā€™m happy to incorporate any feedback to make this PR more useful. :)

One unresolved issue is related to api/threats.js which appears to indicate that GOOGLE_CLOUD_API_KEY may be intended to work for both Page Speed Insights (Lighthouse) and Google Safe Browsing. Any clarification here would be greatly appreciated.

The gist of this update is to rename the API key environment variable and to provide a more direct URL to assist users with adding support for the Quality Summary section of the report.

Additionally, this may introduce a breaking change for current users as they would need to modify their environment variables. Iā€™m not sure how to best handle this type of situation.

netlify[bot] commented 4 months ago

Deploy Preview for web-check ready!

Built without sensitive environment variables

Name Link
Latest commit d738aafa1183abd979b3b98896c37bb3e75d20f7
Latest deploy log https://app.netlify.com/sites/web-check/deploys/65e230fdefa88c0008240efd
Deploy Preview https://deploy-preview-99--web-check.netlify.app/
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

pauljmartinez commented 4 months ago

Totally not necessary and I'd be happy to resubmit without making that change!

I'm unable to tell if that key I generated at https://developers.google.com/speed/docs/insights/v5/get-started is able to be used by the Google Safe Browsing service though.

Lissy93 commented 4 months ago

I'm unable to tell if that key I generated at https://developers.google.com/speed/docs/insights/v5/get-started is able to be used by the Google Safe Browsing service though.

It's the same key, but you need to enable the safe browsing API in the Google dev dashboard