Better Category Loading

Listoka / bittoka

4 stars 1 forks source link

Better Category Loading #229

Open robbyphillips opened 5 years ago

robbyphillips commented 5 years ago

Done:

Move SubNav component to top-level App, and put in a <Route> that matches root and /categories/:categoryName routes
remove references to categories.json
Instead, load categories once when App mounts and pass that data to page components
Refactor MainPageContainer to accept a categories prop, which is an array of category data

TODO:

Refactor the EditorPageContainer to accept the categories array prop... (it's a lot)

robbyphillips commented 5 years ago

EditorPageContainer has been refactored to make use of the top level categories prop. Turns out it really wasn't that big of a deal, but that code could still use some cleanup...

robbyphillips commented 5 years ago

I'm for sure breaking my own rules here by putting unrelated commits into this branch, but they're good little fixes and will merge fine.