Litarvan / lightdm-webkit-theme-litarvan

Litarvan's LightDM HTML Theme
BSD 3-Clause "New" or "Revised" License
707 stars 75 forks source link

Dual monitor with different resolutions #34

Closed xQsme closed 5 years ago

xQsme commented 5 years ago

I have a 1080p secondary monitor and a 1440p main monitor, the blur effect when entering the password is creating a black line at 1920px width, https://imgur.com/a/OQrE9lb

If you can let me know where in the src files the blur effect is located i can try to sort it out myself as you probably can't test this

Also while i'm at it, an option to disable the blur would be nice

Litarvan commented 5 years ago

This is probably because your wallpaper does not the right size, the black line is where the background repeat to cover the entire screen i think

Still, blur is here : https://github.com/Litarvan/lightdm-webkit-theme-litarvan/blob/master/src/views/Base.vue#L46

And yes, i'll try to add a disable blur option you are right, it was even planned at first, i forgot to add it

xQsme commented 5 years ago

the background is the native resolution of my monitor, do you get monitor width/height anywhere in the code? it could be scanning my second monitor

Also there must be something specific with the login view causing this issue as the background renders properly on the clock screen

Litarvan commented 5 years ago

I don't manage monitor width/height, it's html/css it's done normally, i also have dual screen and a 1920*1080 background and it works, i don't really understand, what does it looks without blur ? (on the clock screen)

xQsme commented 5 years ago

https://imgur.com/a/NOa2yAG

from what i've seen the blur itself shouldn't have this effect, not sure what could be causing it

xQsme commented 5 years ago

removed the blur class assignment and built the theme, the black bar is gone, the filter is causing it

closed the issue, might be hard to fix, having the option to disable blur should be enough, let me know if you want me to test a new version

Litarvan commented 5 years ago

It's extremely strange, looks like a bug in webkit itself. New version of web greeter is using qt-webview, definetely better but currently definetely not stable, couldn't run the theme on it after spending 3 hours to manage to build it.

I'll add an option to disable blur