search

LiteLDev / LegacyScriptEngine

A plugin engine for running LLSE plugins on LeviLamina
https://lse.liteldev.com/
GNU General Public License v3.0
43 stars 8 forks source link

fix: Make onPlaceBlock event returning block face #119

Closed VinkyV closed 4 months ago

VinkyV commented 4 months ago

What does this PR do?

Make onPlaceBlock event returning block face and edit docs for this event

Which issues does this PR resolve?

None

ShrBox commented 4 months ago

https://github.com/LiteLDev/LegacyScriptEngine/commit/9c81c2dc8947cb7ada0029b19eb22bf973dbc0c8 LegacyScriptEngine's main task is keep the compability of old LLSE plugins

VinkyV commented 4 months ago

Wait but it continue supporting old plugins... It's just adding new useful argument that other could not use

ShrBox commented 4 months ago

Could I add a new updated event? Same functionality with different name maybe

I have merged this pr, but fix truePos pre calculating. If you need the original BlockPos, just calculating it.

VinkyV commented 4 months ago

Oh, okay, I just misunderstood, thx