search

LiteratureInContext / LiC-app

Application development for Literature in Context. Staging on development branch (http://anthologydev.lib.virginia.edu), production on master (http://anthology.lib.virginia.edu).
Other
6 stars 1 forks source link

displaying videos in annotations #191

Open tonyahowe opened 1 year ago

tonyahowe commented 1 year ago

We don't currently have a way to do this, but is there a way to display videos within annotations? Now, we use links out, but it would be nice to enable videos to show up as playable within annotations. I don't know how to get started on this in the xml. Do you have any ideas?

wsalesky commented 1 year ago

@tonyahowe Can you give me a record to use as a test case?

tonyahowe commented 1 year ago

shakespeare-tempest.xml has a youtube video linked in a note, around line

  1. It would make sense to be able to do uploaded videos (AWS), youtube, and vimeo?

On Fri, Aug 4, 2023 at 9:05 AM Winona Salesky @.***> wrote:

@tonyahowe https://github.com/tonyahowe Can you give me a record to use as a test case?

— Reply to this email directly, view it on GitHub https://github.com/LiteratureInContext/LiC-app/issues/191#issuecomment-1665579139, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAIZTOC6TDD4F2ZIRUEEUYDXTTXSPANCNFSM6AAAAAA2RRRDV4 . You are receiving this because you were mentioned.Message ID: @.***>

-- @howet tonyahowe.com

wsalesky commented 11 months ago

@tonyahowe We can include video's in an iframe, would you like me to do that and put on the dev server for testing?

tonyahowe commented 10 months ago

Yes, let's see how that works!

wsalesky commented 10 months ago

@tonyahowe Done. Let me know what you think.

tonyahowe commented 8 months ago

I don't think I saw this--can you explain how the iframe is created from the XML? Now that we have a way to caption and source images, we should probably also do the same for videos (and audio). Would it be worth doing something like for video? I'm not sure what the best way is to do this--the most stable way. I'll reopen this just to keep it on my radar.

wsalesky commented 8 months ago

Currently the iframe is only created for youtube videos as you can not use the video tag to display youtube videos in HTML. We can discuss the different ways video/audio will show up in the files so I can make sure to catch all variations. Let's discuss in the meeting.

tonyahowe commented 7 months ago

This is something we need to figure out--thanks, Winona! Maybe we can chat about it on slack. @jobrien62