search

LiteratureInContext / LiC-app

Application development for Literature in Context. Staging on development branch (http://anthologydev.lib.virginia.edu), production on master (http://anthology.lib.virginia.edu).
Other
6 stars 1 forks source link

On page image display, problem with text #80

Closed tonyahowe closed 4 years ago

tonyahowe commented 4 years ago

When the page images are viewed on poems (I have not checked this with prose), the last line of text is cut off. See, for instance, https://anthologydev.lib.virginia.edu/work/Wheatley/wheatley-rebus?view=pageImages.

wsalesky commented 4 years ago

@tonyahowe investigating.

wsalesky commented 4 years ago

@tonyahowe Fixed!

tonyahowe commented 4 years ago

Great! What was the problem? It's an interesting little oddity, and it's not a problem with prose pieces. Must have something to do with the line groups or the lines?

On Thu, Sep 26, 2019 at 10:33 AM Winona Salesky notifications@github.com wrote:

@tonyahowe https://github.com/tonyahowe Fixed!

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/LiteratureInContext/LiC-app/issues/80?email_source=notifications&email_token=AAIZTOFHMQ6YMSVXD376S5DQLTB2HA5CNFSM4IYEB632YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD7VZA5Q#issuecomment-535531638, or mute the thread https://github.com/notifications/unsubscribe-auth/AAIZTOAIPTRIRAZ3YEIRRDLQLTB2HANCNFSM4IYEB63Q .

-- Professor of Literature Chair, Department of Literature & Languages https://www.marymount.edu/Academics/School-of-Arts-Sciences/Undergraduate-Programs/English-(B-A-) twitter https://twitter.com/MU_English | Facebook https://www.facebook.com/marymount.english/ | LinkedIn https://www.linkedin.com/in/marymount-english-98b781163/ | Instagram https://www.instagram.com/marymountenglish/ https://marymountuniversity.zoom.us/my/thowe Marymount University Butler G126 703.284.5762 http://cerisia.cerosia.org @howet https://twitter.com/#%21/howet

Co-PI Literature in Context: An Open Anthology of Literature in English, 1660-1830 http://anthologydev.lib.virginia.edu

Digital Humanities Section Editor ABO: An Interactive Journal for Women in the Arts, 1640-1830 http://scholarcommons.usf.edu/abo/

Web and Publications Editor

Virginia Humanities Conference http://vahumanitiesconference.org/

wsalesky commented 4 years ago

I 'borrowed' the code for this from https://wiki.tei-c.org/index.php/Milestone-chunk.xquery

However the way this code handles final pages, i.e. a tei:pb with content following it is a bit simplistic and clearly prone to bugs. It finds the last node after the last milestone, in this case it was finding and stoping at the tei:hi element in the last line of the poem. I rewrote it to work with an empty end page variable, so it gathers all content after that last milestone. Hopefully this is more robust. This could also become a problem if pages are structured with text before the first tei:pb (or other milestone) element, but the same solution should apply, I would just have to make a small adjustment.