search

LithApp / Lith

Multiplatform, mobile-focused WeeChat relay client
https://lith.app
GNU General Public License v2.0
75 stars 7 forks source link

Use QSortFilterProxy for toggling join/quit messages #103

Closed chinese-soup closed 2 years ago

chinese-soup commented 2 years ago

This fixes an issue with using visible: in QML from #101 when users sets a non-zero message spacing in the Settings dialog since the ListView items disappear, but they are still "there", therefore I've replaced it with a QSortFilterProxy in the C++ code.

Spacing now works properly with the messages not being in the model at all (set to 13 in these screenshots): Show joins: mTlu229

Hide joins: XpeyV24

chinese-soup commented 2 years ago

Video (again, with spacing set to 13 to demonstrate the spacing fix):

https://user-images.githubusercontent.com/5108747/143131123-e1c9c0b3-9ba4-4679-8ac6-f19699abc819.mp4

MartinBriza commented 2 years ago

👏