chinese-soup
commented
3 years ago Also other stuff around text formatting is slightly broken still (but only background color seems to crash the client):
- Bold text formatting is still not perfect
- Underline text doesn't work.
- Inverted text doesn't work.
Steps to reproduce the above screenshot:
- Underline (first 2 lines): Press: Ctrl-C -> press _ (underscore) -> write text
- Inverted text (3rd line): Press: Ctrl-C -> press V -> write text
- F|05HELLO lines: Press Ctrl-C type B -> press Ctrl-C type C -> type 3 (color number) -> write text aka: BC3HELLO - meaning bold and a color right after that
Line 471 data =
"*|05~05cThis doesn't always happen (as you can see in the video it took a second try) but is reproducible quite a lot! Do not test on a buffer you aren't afraid to clear, as this crashes the client (almost) everytime the buffer with the characters is opened.
Video (with steps to reproduce): http://povidam.ahoj.club/2020-11-15_23-33-33.mp4
Steps to write a bg+fg message: in weechat press: Ctrl-C then type: 3,3c
where "c" is any message you want to write with green text and green background
On an unrelated note: as you can see, even if it doesn't crash, the message gets mangled as I assume we don't parse background colors at all?