search

LittleDevMars / pyftpdlib

Automatically exported from code.google.com/p/pyftpdlib
Other
0 stars 0 forks source link

Logging setup should be done on pyfptdlib logger #283

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
Logging setup should always rely on pyftpdlib logger and not the root logger
The implementation in log.py is not consistent :
    - default logger is defined as logging.getLogger('pyftpdlib') in log.py
    - setup (log.py) and test (_IOLoop.loop & FTPServer._log_start) are done on logging.getLogger()

What version of pyftpdlib are you using?
1.0.1

On what operating system?
Solaris & GNU/Linux

Which Python version?
2.7.5

Original issue reported on code.google.com by jah...@gmail.com on 4 Apr 2014 at 12:59

GoogleCodeExporter commented 9 years ago 
Please take a look at r1250. Does it make sense?

Original comment by g.rodola on 4 Apr 2014 at 1:11

GoogleCodeExporter commented 9 years ago 
Yes, it's what I was expecting.
Thanks.

Original comment by jah...@gmail.com on 4 Apr 2014 at 1:14

GoogleCodeExporter commented 9 years ago

Original comment by g.rodola on 11 Apr 2014 at 4:33

GoogleCodeExporter commented 9 years ago

Original comment by g.rodola on 3 Jun 2014 at 9:46