search

LittleLightForDestiny / littlelight

Little Light is an inventory manager/companion app for Destiny 2 for both iOS and Android. It helps guardians move their gear and track their ingame progress.
MIT License
161 stars 31 forks source link

add chrome os support #107

Closed YamazakiRobert closed 3 years ago

YamazakiRobert commented 3 years ago

you can't login using chrome on chrome os and have to install the chrome beta or dev to login and the icons for perks are blurry to see

joaopmarquesini commented 3 years ago

1) That's an issue with the default chromeOS browser and android apps in general, so I don't think there's something I can do to fix it. 2) I need to check if I'm able to reproduce this issue somehow to debug it, but unfortunately I don't have a chrome OS device. I'm going to research if there's something I can do to fix it or if that's a framework incompatibility issue and all I can do is wait.

YamazakiRobert commented 3 years ago

you can use brunch https://github.com/sebanc/brunch to test chrome os support i don't know if is possible to little light to use a hook to WebView or another browser render to open the login screen inside the app https://developer.android.com/guide/webapps https://stackoverflow.com/questions/32984955/how-to-open-web-page-within-my-app

joaopmarquesini commented 3 years ago

I don't think that would solve the issue, as it's chromeOS default chrome browser that won't "talk" to android apps. An internal webview on the app will be based on the system OS and will likely have the same problem. Also it goes against Bungie guidelines to show their login page as a part of the app (chrome custom tabs and safari controller view are ok though). As there's already a workaround for that (by using another browser) I wouldn't consider that an issue to be fixed on LL.