Default perk's availability should be checked too

[kj415j45]

Issue originally reported in Discord by Swerlz

Weapon "Tigerspite"<640114618>.socket[3] has a default value (or say singleInitialItemHash) which is "Kill Clip"<1015611457>. However, in its randomizedPlugSetHash <1765257316> there's no "Kill Clip" at all. That means "Kill Clip" will never appear on that slot.

Currently LL would not marked it as invalid perk in Collections screen, while it should be.

[joaopmarquesini]

Is that the case for all weapons ? Aren't the contents of singleInitialItemHash the "Bungie roll" for some weapons ?

[kj415j45]

Is that the case for all weapons ? Aren't the contents of singleInitialItemHash the "Bungie roll" for some weapons ?

I think Bungie just use singleInitialItemHash for items' showcase in Collections scrren. There's an extra example, "Chattering Bone"<568515759> has a kill clip at 3rd perk slot's singleInitialItemHash, but it will never appear on random-roll version of this weapon. It can only drop on curated version.

However, it looks like only weapons release before Shadowkeep has the similar issue. I'm not sure about this since we have so much weapon.

[joaopmarquesini]

@kj415j45 can you confirm if this is still wrong in the current version ?

[kj415j45]

@kj415j45 can you confirm if this is still wrong in the current version ?

@joaopmarquesini It's still wrong in 2.0.1.

[kj415j45]

Btw, I can not see other perks with currentlyCanRoll: false being marked as not available in this view either.

[bill0042]

Also, perks on collectible items have the option to "Apply trait". Sticky grenades on Wendigo GL3 is one example with "currentlyCanRoll: false" that the previous version showed as disabled, but no longer shows that. For perks that are only in singleInitialItemHash (only roll on the curated version), I think there are so few cases of this and on such old weapons, that it doesn't matter that we show these perks as normal perks.

[joaopmarquesini]

let me see if I understand: we shouldn't show singleInitialHash when we have randomPlugSet unless it's included on randomPlugSet Additionally, we should disable singleInitialHash (and all other plugs) that have currentlyCanRoll:false. Is that right ?