search

LittleLightForDestiny / littlelight

Little Light is an inventory manager/companion app for Destiny 2 for both iOS and Android. It helps guardians move their gear and track their ingame progress.
MIT License
159 stars 31 forks source link

Need to disable Impeller on iOS until PaintingStyle.stroke is fixed #250

Closed bill0042 closed 1 year ago

bill0042 commented 1 year ago

LL is using PaintingStyle.stroke to render dark outlines around white text to make it more readable on light backgrounds. Flutter 3.10, by default, enables a new Impeller rendering engine (https://docs.flutter.dev/perf/impeller) on iOS which has not yet implemented PaintingStyle.stroke (https://github.com/flutter/flutter/issues/126010). We need to disable Impeller until this issue is resolved.

From (https://docs.flutter.dev/perf/impeller#ios):

To disable Impeller on iOS when deploying your app, add the following tags under the top-level tag in your app’s Info.plist file.

<key>FLTEnableImpeller</key> <false />

Jeanno commented 1 year ago

Do you notice any performance issue with impeller disabled?

bill0042 commented 1 year ago

I haven't done any comparison. We just started using Flutter 3.10 which is the first time it is enabled by default and then I started looking at this issue.

joaopmarquesini commented 1 year ago

I would rather find an alternative for the strokes, as we don't use them a lot.