Wishlists PvP vs. PvE labeling

[franciscoaraposo]

How can I specify whether a god roll is PvP or PvE in a wishlist file? What part of the code is parsing the wishlist file?

[joaopmarquesini]

if you add #notes:|tags:pve,pvp,curated,trash,🤢 it will add the respective tag. if it doesn't have those tags, it will try to parse it from the current item notes or name. check lib/services/littlelight/dim_wishlist.parser.dart

[franciscoaraposo]

well... the parsing is bugged. for instance, when I go check my PvE godroll Pyroclastic Flow, the example below wrongly highlights Quick Launch, Impact Casing, and Ambitious Assassin as godroll perks for both PvP and PvE, even though they are PvP-only, PvE-only, and PvE-only godrolls, respectively:

this is the example wishlist code:

// Pyroclastic Flow // Quick Launch, High-Velocity Rounds, Quickdraw, Cluster Bomb //tags:pvp dimwishlist:item=1289324202&perks=981914802,2822142346,706527188,1275731761 // Volatile Launch, Impact Casing, Ambitious Assassin, Cluster Bomb //tags:pve dimwishlist:item=1289324202&perks=1478423395,3796465595,2010801679,1275731761

It seems the parsing is bugged only when there are pvp and pve godrolls for the same weapons in the wishlist...

[joaopmarquesini]

If you're using generic notes (// or //notes:) you need to add an empty line between builds. Eg:

// Pyroclastic Flow
// Quick Launch, High-Velocity Rounds, Quickdraw, Cluster Bomb
//tags:pvp
dimwishlist:item=1289324202&perks=981914802,2822142346,706527188,1275731761

// Pyroclastic Flow
// Volatile Launch, Impact Casing, Ambitious Assassin, Cluster Bomb
//tags:pve
dimwishlist:item=1289324202&perks=1478423395,3796465595,2010801679,1275731761

But the best way to do what you're trying to achieve is using specific tags. Eg:

// Pyroclastic Flow
dimwishlist:item=1289324202&perks=981914802,2822142346,706527188,1275731761#notes=Quick Launch, High-Velocity Rounds, Quickdraw, Cluster Bomb|tags:pvp
dimwishlist:item=1289324202&perks=1478423395,3796465595,2010801679,1275731761#notes=Volatile Launch, Impact Casing, Ambitious Assassin, Cluster Bomb|tags:pve

[franciscoaraposo]

Thank you for clarifying this.

Is there any reference link for learning the full syntax rules for wishlists?

[joaopmarquesini]

Not yet, but I'm adopting a new format which makes more sense for little light. Also I plan to make a GUI wishlist builder in the future.

Em qua, 26 de fev de 2020 10:12, franciscoaraposo notifications@github.com escreveu:

Thank you for clarifying this.

Is there any reference link for learning the full syntax rules for wishlists?

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/LittleLightForDestiny/littlelight/issues/56?email_source=notifications&email_token=AACKO7UZ6BKBNGBZEMUUO4DREZTENA5CNFSM4K2X2LO2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOENAFK4Q#issuecomment-591418738, or unsubscribe https://github.com/notifications/unsubscribe-auth/AACKO7QQCOIE327KHRJKNXLREZTENANCNFSM4K2X2LOQ .

[joaopmarquesini]

If you want to take a look, the new format looks like this:

https://raw.githubusercontent.com/LittleLightForDestiny/csv-wishlists-parser/master/output/pandapaxxy-forge.json

There's a parser for that format here: https://github.com/LittleLightForDestiny/csv-wishlists-parser That accepts csv like these: https://github.com/LittleLightForDestiny/csv-wishlists-parser/blob/master/csv/pandapaxxy-forge.csv

[franciscoaraposo]

When I do (after specifying the perk codes in the same line):

notes:Range|tags:pvp

it now correctly displays the godroll type (PvP, in this example). However, the "|tags:pvp" also shows up in the notes :(

[joaopmarquesini]

yep, that's unfortunately a downside of the dim wishlist format.

On Thu, Feb 27, 2020 at 12:16 PM franciscoaraposo notifications@github.com wrote:

When I do (after specifying the perk codes in the same line):

notes:Range|tags:pvp

it now correctly displays the godroll type (PvP, in this example). However, the "|tags:pvp" also shows up in the notes :(

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/LittleLightForDestiny/littlelight/issues/56?email_source=notifications&email_token=AACKO7VM4XOSRK66II63F6LRE7KOFA5CNFSM4K2X2LO2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOENEW5UI#issuecomment-592015057, or unsubscribe https://github.com/notifications/unsubscribe-auth/AACKO7RE6EE4ABDXWZL5HKLRE7KOFANCNFSM4K2X2LOQ .