search

LittleLin / Android-BootCamp-InstagramPhotoViewer

0 stars 1 forks source link

[Android Bootcamp] Project 2 - Instagram Photo Viewer - Ready for Review #1

Open LittleLin opened 9 years ago

LittleLin commented 9 years ago

My app is complete, please review. Thank you.

@nidhi1608 and @thecodepath

I also have a question about DialogFragment while I implementing this App. I used DialogFragment and ListView to display all the comments of each photo. But in my App, ListView can't scroll inside DialogFragment, it just shows single page comments and I can't scroll the ListView down to see further comments.

Did I do anything wrong?

Jonathan Lin (jonalin@)

nidhi1608 commented 9 years ago

You don't see a scroll bar here because the Instagram api only returns 8 comments in the response data. And since your ListView height is set to wrap_content, there are no items to scroll to. You can verify this by logging the raw json returned from the Instagram endpoint and checking the comments node.

LittleLin commented 9 years ago

Thank you for your quick response. I'll try to fetch full comments by via Instagram's Comments Endpoint API.

Sorry to bother you again, but I have another question after the first question above. In Java wep pages, I always use GSON library to simplify the process of JSON deserialization. Do you suggest we use the same way in android app development?

Thank you.

nidhi1608 commented 9 years ago

GSON is one of the most popular libraries to parse JSON in Android app development as well. Another alternative to GSON is Jackson. You will come across both of these while working with third party libraries. Both are comparable in my opinion. Using GSON is absolutely fine if you are already familiar with it.

nidhi1608 commented 9 years ago

:+1: Excellent submission. I am glad you were able to work on many options and got a chance to play around with pull to refresh and custom CircularImageView.

I have provided a detailed Feedback Guide here which covers the most common issues with this submitted project. Read through the feedback guide point-by-point to determine how you could improve your submission.

Hopefully this first project has given you a better sense of working with RelativeLayout which is a very flexible layout system. This assignment also gave us our first introduction to networking, working with APIs and loading remote images. The next assignment will introduce new concepts such as accepting user input and navigating between activities and will also reinforce important concepts such as networking, using APIs, handling remote images.

Let us know if you have any other thoughts or questions about this assignment.