LittleTechBookClub / swarm-rest-api

This is the Swarm app backend REST API, a Spring Web application.
0 stars 0 forks source link

#15 - Productionize response from ChatGPT #16

Closed idjevm closed 4 months ago

idjevm commented 5 months ago

What does this pull request aim to achieve?

Now we are getting the follow response ->

image

I know a few things can be changed, but those can be on follow up small issues, and small PRs, so we can move past this step of getting the first setup done.

To look at my changes directly look into my commit here

What is left to do from this?

Please be concise and link any related issue(s): closes #15 closes dup #14 closes #13 from @Clue355

Please do NOT submit this PR if you have not done the following:

idjevm commented 5 months ago

@MelisaIm / @lindentree I know that we are not able to add more than one person so I am tagging you here for you all to take a look also and leave any comments.

Reason this PR is big is because it is bringing the changes that @Clue355 had but you can look at the changes directly by seen my commit.

I will work with Carlos to get his PR open so I can use that as a base and then this one will be much cleaner PR :)

Clue355 commented 5 months ago

looks like the test failed in the project. Edit that to make it work

idjevm commented 5 months ago

test is failing

I actually left a comment that I will not be handling tests on this PR but will need to make a separate PR for following TODOs & tests - I might extend from this branch so that way it doesn't become too big, but yeah tests will be handled in a separate PR / branch.

idjevm commented 4 months ago

LGTM! Maybe it would be better to have @fsantamaria1’s PR merged first though, to spread out the contributions.

Yup, I asked him to do that so I am going to hold off for his PR to be merged before merging this one.