LittleTrickster / PDF-Doc-Scan

Android PDF document scanning app
BSD 3-Clause "New" or "Revised" License
140 stars 15 forks source link

Armv8 on IzzyOnDroid #10

Closed machiav3lli closed 1 year ago

machiav3lli commented 1 year ago

@IzzySoft would you please replace the armv7 apks with armv8? Thanks!

IzzySoft commented 1 year ago

@LittleTrickster you're OK with that? It would make the app unavailable to all 32bit devices. The advantages are mostly a possible little performance boost on arm64 devices, and that the app became available to those poor users with Google Pixel 7 plus :speak_no_evil:

PS: An alternative might be a build just covering both ARM ABIs (and only those). That should be less than 15 MB in size, so I still could keep 2 versions available in my repo.

LittleTrickster commented 1 year ago

@IzzySoft I think you should use the arm64 version. I haven't found a simple way to build another apk with two ABIs after splitting.

LittleTrickster commented 1 year ago

Using flavours does work. But it takes ages to build since it does compile, R8, minify and etc... for each individual apk.

assembleRelease

   flavorDimensions "abi"
    productFlavors {
        universal {
            dimension "abi"
            ndk {
                abiFilters "armeabi-v7a", "arm64-v8a", "x86_64", "x86"
            }
        }
        x86 {
            dimension "abi"
            ndk {
                abiFilters "x86"
            }
        }
        x86_64 {
            dimension "abi"
            ndk {
                abiFilters "x86_64"
            }
        }
        armeabi_v7a {
            dimension "abi"
            ndk {
                abiFilters "armeabi-v7a"
            }
        }
        arm64_v8a {
            dimension "abi"
            ndk {
                abiFilters "arm64-v8a"
            }
        }
        arm {
            dimension "abi"
            ndk {
                abiFilters "armeabi-v7a", "arm64-v8a"
            }
        }
    }
IzzySoft commented 1 year ago

I'd leave the decision to you. If you say it should be arm64, I'll prepare the switch. If you don't mind the compile time, I can take the "double arm" one (btw, what size did it turn out to be?).

LittleTrickster commented 1 year ago

@IzzySoft Added 1.03 with app-arm-release.apk ~15MB for both "armeabi-v7a", "arm64-v8a" just use this one.

IzzySoft commented 1 year ago

Thanks! That way neither party can complain (except for size). Still fits in my repo twice, so it's set to keep the current and the previous version.

Btw: would you mind establishing Fastlane structures in your repo here, so you'd be in control of description, graphics etc (i.e. how your app is presented)? My updater would check that along when pulling new versions then. You're welcome to use my Fastlane Cheat Sheet for guidance – and I could even offer you a PR with what's currently set up with my repo, as a starter-package so to say.

machiav3lli commented 1 year ago

Thank you both for your efforts!