Liturgical-Calendar / LiturgicalCalendarAPI

A PHP script / API endpoint that will generate the Roman Catholic liturgical calendar for any given year, calculating the mobile festivities and the precedence of solemnities, feasts, memorials...
Apache License 2.0
39 stars 11 forks source link

[Bug]: Dedication of the Lateran Basilica has wrong rank #182

Closed JohnRDOrazio closed 6 months ago

JohnRDOrazio commented 8 months ago

What happened?

The Dedication of the Lateran Basilica falls on a Sunday in 2025 and takes precendence over the Thirty Second Sunday of Ordinary Time. But the calendar mentions the Thirthy Second Sunday instead and gives the incorrect rank (it should be Feest, but it lists Feest van de Heer).

(feedback from Steven van Roode)

Version

dev (Edge)

Which browser or browsers are you seeing the problem on? (can select more than one, or N/A if not applicable)

N/A

Relevant error messages

No response

JohnRDOrazio commented 6 months ago

The Dedication of the Lateran Basilica has rank FEAST, not FEAST OF THE LORD:

https://github.com/Liturgical-Calendar/LiturgicalCalendarAPI/blob/42d3e81de06da24d0e95be4655ac955c2e865107/data/propriumdesanctis_1970/propriumdesanctis_1970.json#L3247-L3266

Grade 4 is FEAST:

https://github.com/Liturgical-Calendar/LiturgicalCalendarAPI/blob/42d3e81de06da24d0e95be4655ac955c2e865107/includes/enums/LitGrade.php#L41

Feast of the Lord is referring to the Sunday. So the question is: should the dedication of the Lateran Basilica take precedence over the Sunday? And if so, what instruction can we base this on?

JohnRDOrazio commented 6 months ago

It would seem that the Dedication of the Lateran Basilica is considered a Feast of the Lord, I'm seeing in the US calendar that it does indeed outrank the Sunday: https://www.usccb.org/resources/2025cal.pdf

Cathopedia menziona che è considerata una "Festa del Signore" nel rito ambrosiano, ma semplicemente "Festa" nel rito romano: https://it.cathopedia.org/wiki/Dedicazione_della_Basilica_Lateranense#Liturgia

The Italian Wikipedia mentions that it is a "christological feast" (https://it.wikipedia.org/wiki/Dedicazione_della_basilica_lateranense), not that wikipedia means anything.

JohnRDOrazio commented 6 months ago

Fixed in commit https://github.com/Liturgical-Calendar/LiturgicalCalendarAPI/commit/1a5ee88fac4363dd9b04ab5bfc4aa53222550dae

Source: in the Missale Romanum, in the section Index Alphabeticus Celebrationum, under Iesus Christus D. N. the Dedicatio Basilicae Lateranensis is also listed