search

Liturgical-Calendar / LiturgicalCalendarAPI

A PHP script / API endpoint that will generate the Roman Catholic liturgical calendar for any given year, calculating the mobile festivities and the precedence of solemnities, feasts, memorials...
Apache License 2.0
35 stars 9 forks source link

update schemas and tests #192

Closed JohnRDOrazio closed 2 months ago

JohnRDOrazio commented 3 months ago

What happened?

With all the latest changes we need to update the schemas to account for new properties, and update tests to work for both CalendarType::CIVIL and CalendarType::LITURGICAL.

Version

dev (Edge)

Which browser or browsers are you seeing the problem on? (can select more than one, or N/A if not applicable)

N/A

Relevant error messages

No response

JohnRDOrazio commented 2 months ago

Fixed with commits:

Since I couldn't figure out why some tests were still failing, I tried to add the raw JSON data to the ws message (commit https://github.com/Liturgical-Calendar/LiturgicalCalendarAPI/commit/a462e43b51115e1ffba36b4d2d32bf48b18272c8), however I was not seeing this data in the message log in Chrome Developer Tools. Then I thought: maybe I have to restart the websocket server. This is done with sudo service litcal-tests restart. Once the ws server was restarted, voilà no more failed tests (so we're not even needing to see the raw JSON in the message).