Liturgical-Calendar / LiturgicalCalendarAPI

A PHP script / API endpoint that will generate the Roman Catholic liturgical calendar for any given year, calculating the mobile festivities and the precedence of solemnities, feasts, memorials...
Apache License 2.0
44 stars 11 forks source link

refactor diocesan ids to follow new `WorldDiocesesByNation.json` asset #238

Closed JohnRDOrazio closed 3 weeks ago

JohnRDOrazio commented 3 weeks ago

We now have all dioceses of the world, at least for the Latin rite, thanks to a contribution from G. Chow.

The names of the dioceses all use Latin characters. Perhaps in the future we can adapt with additional localized names where appropriate, for example with Chinese characters for the diocese in China, etc.

In any case we now have a pre-generated id to uniquely identify each diocese of Latin rite, so there is no need to generate the id on the fly when creating a new diocesan calendar.

We should update all references to diocesan ids as well as folder names / file names to use these pre-generated ids.

JohnRDOrazio commented 3 weeks ago

completed in commits: https://github.com/Liturgical-Calendar/LiturgicalCalendarAPI/compare/bf035e6e1eb6e737dbd286d1aa104a88eea90aeb..e15930a8106cc69a1f7af0c6121f850307cbbed8