Litzuck / lol-spectator-overlay-client

A client that produces an overlay similar to that of the one used in the broadcasts of LoL Esports during 2015-2017
MIT License
28 stars 10 forks source link

Issue with the background of both timers #3

Closed Kinsoh closed 3 years ago

Kinsoh commented 3 years ago

What happens is that at the end of all the picks and bans, when there are 60 seconds left for the game to start, "Picking Phase 2" continues to appear in the middle of both timers with the color red in the background, and both timers still have the red color in the background. The correct thing is that the background of both timers should turn black and the text "Picking Phase 2" should disappear along with the red background of the same.

I am going to put 2 images of what happens and how it should be correctly. 1 2

Litzuck commented 3 years ago

Thanks for pointing this out. It should have been fixed in the last release, but I'll look into it.

Kinsoh commented 3 years ago

Thanks for pointing this out. It should have been fixed in the last release, but I'll look into it.

Ok thanks!

Litzuck commented 3 years ago

I wasn't able to replicate this bug with on my side. Could you please send me the log file of the champion select, which caused this issue. It can be found in the logs folder and is named replay_TIMESTAMP.json.

Kinsoh commented 3 years ago

I wasn't able to replicate this bug with on my side. Could you please send me the log file of the champion select, which caused this issue. It can be found in the logs folder and is named replay_TIMESTAMP.json.

Github doesn't allow me to upload these types of files, do you have discord or something to talk about and send the file easier?

Litzuck commented 3 years ago

Yes you can add me on Discord: Litzuck#5760.

Litzuck commented 3 years ago

Problem solved. Currenty intended behavior if lobby is not full. Closing issue.