List order changes unexpectedly when editing tags from breakfast to dinner

[LiuFangrui]

1. add n/hotpot c/1613 t/dinner will add hotpot as dinner
2. add n/bread c/100 t/breakfast will add bread as breakfast
3. bread is at index 1 and dinner is at index 2
4. edit 1 t/dinner will change bread to dinner, now dinner is at index 1 and bread is at index 2

when users have a large list of food items, for example 8 (a reasonable number), and adds a dinner item 21 wrongly tagged as breakfast, when user changes the tag to dinner for this "breakfast" item, user might experience the food item suddenly "disappearing" as it has been moved to the bottom of the list, and cause confusion as sorting order is not explicitly defined.

[nus-se-script]

[IMPORTANT!: Please do not edit or reply to this comment using the GitHub UI. You can respond to it using CATcher during the next phase of the PE]

Team's Response

We stated in our UG that our list is sorted by mealtype: breakfast -> lunch -> dinner! Therefore, it is intended behavior that once the mealtype is edited from breakfast to dinner, the meal item would be moved to the bottom of the list together with all the meal items tagged as dinner. Additionally, we believe that if the list is not sorted, it may actually be harder for the user to find their food.

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

• [ ] I disagree

Reason for disagreement: [replace this with your reason]

---