search

LiuMC-SG / pe

0 stars 0 forks source link

Edit command does not check for duplicate email. #16

Open LiuMC-SG opened 1 year ago

LiuMC-SG commented 1 year ago

Similar to add command, different students would have unique emails and should not have the same as per NUS policy since this is for NUS teaching assistants.

Hence, edit should not allow it as well.

For example edit 11 e/lidavid@example.com with email matching sample data does not work

image.png

soc-se-bot commented 1 year ago

Team's Response

Fair point. However, we feel that this does not affect the usability of the app very much, except in cases of typos. Like you said each student has a unique NUS email, hence while inputting the email, the user can safely input all the students email knowing that they are by default unique, so this feature flaw is not critical.

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: image.png

Based on this, since there is a duplicate detection feature based on naming, duplicate email should also be checked.

The application should be able to provide a warning as specified or have it as an error.

## :question: Issue severity Team chose [`severity.Low`] Originally [`severity.Medium`] - [ ] I disagree **Reason for disagreement:** [replace this with your explanation]