LiuzLab / AI_MARRVEL

AI-MARRVEL (AIM) is an AI system for rare genetic disorder diagnosis
GNU General Public License v3.0
8 stars 5 forks source link

Modify exonic filtering parameters and add bed filter option #48

Closed hyunhwan-bcm closed 1 month ago

hyunhwan-bcm commented 1 month ago

Description

We need to make changes to the exonic filtering parameters in our Nextflow script to improve clarity and add more flexibility. This involves renaming an existing parameter and adding a new one with higher priority.

Proposed Changes

  1. Rename --no_filter_exonic to --exome_filter
  2. Add a new parameter --bed_filter
  3. Modify the filtering logic to prioritize --bed_filter over --exome_filter

Implementation Details

1. Rename parameter

2. Add new parameter

3. Modify filtering logic

Code Changes

Update the FILTER_EXONIC process (around line 53) to something like this:

Tasks

jylee-bcm commented 1 month ago

Do you mean the default behavior is not performing the filtering? then it's good.

hyunhwan-bcm commented 1 month ago

please read the entire document carefully, this issue not only asking this but also add additional thing needs to be done. The current version the default parameter no_filter_exonic = false, then I believe it executes a filtering as default, isn't it?

jylee-bcm commented 1 month ago

Gotcha. I will work on it

hyunhwan-bcm commented 1 month ago

Thanks!