Clean main.nf - Githubissues

LiuzLab / AI_MARRVEL

AI-MARRVEL (AIM) is an AI system for rare genetic disorder diagnosis

GNU General Public License v3.0

8 stars 6 forks source link

Clean main.nf #65

Closed jylee-bcm closed 3 months ago

jylee-bcm commented 3 months ago

I would like to clean a little bit about the main.nf.

[x] Separate functions from processes
[x] Use named outputs

Feel free to feedback the changes!

ZaahidShaik commented 3 months ago

Can you run these cmd's and add the output in the PR details section. To verify you changes.

Checking help.
```
nextflow run main.nf --help
```
Checking the error are working fine. Just give the same VCF file path as input in both --input-vcf & --input-hpo or any non '.txt' / 'hpo' files. You should get these errors.

Error: '--input_hpo' value '/home/sample/sample.vcf.gz' should be an HPO file (.hpo) or (.txt)

  To see usage and available parameters run `nextflow run main.nf --help`

ZaahidShaik commented 3 months ago

Verified in person with @jylee-bcm, Approving!

jylee-bcm commented 3 months ago

@ZaahidShaik @hyunhwan-bcm Thank you for reviewing, but I added one thing more regarding named output. I would like to get your approval once again!

jylee-bcm commented 3 months ago

Oh! haha.. already merged. Thanks!